Skip to content

Issue 597 add the huber norm - #1195

Closed
aringh wants to merge 5 commits into
odlgroup:masterfrom
aringh:issue_597__add_the_huber_norm
Closed

Issue 597 add the huber norm#1195
aringh wants to merge 5 commits into
odlgroup:masterfrom
aringh:issue_597__add_the_huber_norm

Conversation

@aringh

@aringh aringh commented Oct 16, 2017

Copy link
Copy Markdown
Member

Part of #597. Implements Huber norm with gradient and proximal operator.

@mehrhardt

mehrhardt commented Oct 18, 2017

Copy link
Copy Markdown
Contributor

It looks quite good to me. There is a current pull request #1191 in which I do the same. However, we both focus on different aspects of the Huber norm and it would be good to merge the two. I did not bother with gradient as I don't need it but therefore included the convex conjugate. Moreover, my version is slightly more general as it allows to operate on vector-valued functions. Again this is due to my application.

@kohr-h

kohr-h commented Oct 18, 2017

Copy link
Copy Markdown
Member

Merging in the Git sense doesn't make any sense here, so my suggestion is that one just cherry-picks the good parts from the other. Probably you would have less to pick @mehrhardt, so I'd assume it would be easier to merge that way. We'll then close the other PR and merge the merged one.

@adler-j

adler-j commented Oct 19, 2017

Copy link
Copy Markdown
Member

I agree with @kohr-h, this should be cherry-picked to the other branch.

@mehrhardt

Copy link
Copy Markdown
Contributor

I now combined this version of the Huber norm with my version in #1191.

@aringh

aringh commented Oct 19, 2017

Copy link
Copy Markdown
Member Author

Sounds good to me :-) I guess we close this?

@adler-j

adler-j commented Oct 19, 2017

Copy link
Copy Markdown
Member

Closing this, terribly sorry about the double work for you @aringh

@adler-j adler-j closed this Oct 19, 2017
@kohr-h

kohr-h commented Oct 19, 2017

Copy link
Copy Markdown
Member

At least large parts of the documentation and the tests made it, plus the gradient, so it was still very useful.

@mehrhardt

Copy link
Copy Markdown
Contributor

Oh, I recycled pretty much all of it. Our contributions complemented each other very well @aringh.

@aringh

aringh commented Oct 19, 2017

Copy link
Copy Markdown
Member Author

No worries. The important thing is make odl develop, and also hopefully learning a thing or two on the way ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants