Issue 597 add the huber norm - #1195
Conversation
|
It looks quite good to me. There is a current pull request #1191 in which I do the same. However, we both focus on different aspects of the Huber norm and it would be good to merge the two. I did not bother with gradient as I don't need it but therefore included the convex conjugate. Moreover, my version is slightly more general as it allows to operate on vector-valued functions. Again this is due to my application. |
|
Merging in the Git sense doesn't make any sense here, so my suggestion is that one just cherry-picks the good parts from the other. Probably you would have less to pick @mehrhardt, so I'd assume it would be easier to merge that way. We'll then close the other PR and merge the merged one. |
|
I agree with @kohr-h, this should be cherry-picked to the other branch. |
|
I now combined this version of the Huber norm with my version in #1191. |
|
Sounds good to me :-) I guess we close this? |
|
Closing this, terribly sorry about the double work for you @aringh |
|
At least large parts of the documentation and the tests made it, plus the gradient, so it was still very useful. |
|
Oh, I recycled pretty much all of it. Our contributions complemented each other very well @aringh. |
|
No worries. The important thing is make |
Part of #597. Implements Huber norm with gradient and proximal operator.